bitbake.git
6 years agoUpdate version to 1.17.0 1.17.0
Richard Purdie [Mon, 26 Nov 2012 09:55:32 +0000 (09:55 +0000)]
Update version to 1.17.0

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agofetch2: Avoid using FILESDIR in unpack
Richard Purdie [Thu, 22 Nov 2012 21:41:21 +0000 (21:41 +0000)]
fetch2: Avoid using FILESDIR in unpack

Currently there is code which uses FILESDIR in unpack to ensure
parent directories are created, leading to differing behaviour depending on
which search path is used to locate the directory.

This change standardises the code and takes the data from the fetcher in
question meaning we can standardise the code and deprecate FILESDIR.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agofetch2/local: Improve handling of wildcard matches
Richard Purdie [Thu, 22 Nov 2012 21:40:18 +0000 (21:40 +0000)]
fetch2/local: Improve handling of wildcard matches

Currently wildcard matches end up working by FILESDIR being defined
in the metadata to a default of "." in FILESPATH which is hacky at best.

This patch adds the behaviour into the fetcher so its at least slightly
more explicit.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoknotty/msg: Avoid usage of curses initscr/endwin to avoid terminal corruption
Richard Purdie [Sun, 25 Nov 2012 21:17:41 +0000 (21:17 +0000)]
knotty/msg: Avoid usage of curses initscr/endwin to avoid terminal corruption

Using curses initscr/endwin causes screen corruption if for example you
suspend bitbake and resume it. This changes the code to use a less
invasive approach to determining colour availability on the terminal.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob/builder: Don't rerun sanity checks
Constantin Musca [Tue, 20 Nov 2012 08:09:18 +0000 (10:09 +0200)]
hob/builder: Don't rerun sanity checks

Run the sanity check only once

[YOCTO #3377]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: showing when build fails because out of disk space
Cristiana Voicu [Tue, 20 Nov 2012 12:37:46 +0000 (14:37 +0200)]
hob: showing when build fails because out of disk space

-to enable this in hob, first you have to enable this in bitbake using
BB_DISKMON_DIRS and/or BB_DISKMON_WARNINTERVAL vars
-created "restart the build" action on the build_fail_top_bar

[YOCTO #3357]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoserver/process.py: Change timeout error handling
Richard Purdie [Wed, 21 Nov 2012 09:15:34 +0000 (09:15 +0000)]
server/process.py: Change timeout error handling

In normal usage, we never hit the timeout issue. If we do, it becomes obvious
that the current error handling is not good enough. The request may have made it
to the server and the answer will get queued. This means the next command may get
the return value from the previous command with suitably puzzling results.

Without rewriting large sections of code, its not possible to avoid this problem.
It is better to increase the timeout to several seconds giving the server a chance
to respond and if it does timeout, hard exit since recovery is not possible with the
code base today.

I'd be happy to see the structure of this code improved but this quick fix at least
stops corrupted builds from happening which has to be a good thing.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoknotty: Colorize knotty interactive console output
Seth Bollinger [Fri, 16 Nov 2012 01:29:40 +0000 (19:29 -0600)]
knotty: Colorize knotty interactive console output

Add bold color output to log level name and standard color output to log msg
when bitbake is run from an iteractive console.  Color output is only
enabled
if the terminal supports color.

Used Jason Wessel's recommendation for transparency on verbose, note and
plain.

Signed-off-by: Seth Bollinger <seth.boll@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: warnings during the build should be displayed in the Issues tab
Cristiana Voicu [Tue, 13 Nov 2012 14:48:46 +0000 (16:48 +0200)]
hob: warnings during the build should be displayed in the Issues tab

Any issues encountered during the build (fatal or not) is displayed
in the Issues tab, and the total number of issues is changed.

[YOCTO #3376]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agorunqueue: Allow partial setscene task coverage
Richard Purdie [Fri, 16 Nov 2012 15:30:52 +0000 (15:30 +0000)]
runqueue: Allow partial setscene task coverage

When the setscene code was originally written it was thought that we'd
allow "partial" coverage. For example, if we just want to build the target
"bash:do_populate_sysroot" and its available from sstate, it makes no sense
to install gcc-cross's sstate package as its simply not needed.

Due to various other issues in the codebase, this functionality was
disabled/removed to allow the setscene code and sstate to stabilise and allow
us to concentrate on other problems.

The time has now come to enable "partial" coverage. There are two major changes
in this patch:

a) Creation of an unskippable list. This lists direct dependencies of
   build targets and hence things that cannot be skipped.

b) Addition of a handler which looks at a given setscene target and what depends
   on it and then decides whether its necessary.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoparse/cache/cooker: Preserve order in the file inclusion list
Richard Purdie [Mon, 19 Nov 2012 15:01:20 +0000 (15:01 +0000)]
parse/cache/cooker: Preserve order in the file inclusion list

The data returned by get_file_depends() may me used in contexts like
checksums where order is important. The current usage of sets means
that some of the checksums can change in circumstances they should not.

This patch changes to use lists, thereby removing the problem.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoknotty: kill duplicated import of 'time'
Christopher Larson [Tue, 13 Nov 2012 19:12:50 +0000 (12:12 -0700)]
knotty: kill duplicated import of 'time'

The duplicated import could result in an UnboundLocalError.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoprint clear message for "bitbake -e ASSUME_PROVIDED"
Robert Yang [Tue, 6 Nov 2012 12:18:42 +0000 (20:18 +0800)]
print clear message for "bitbake -e ASSUME_PROVIDED"

"bitbake -e ASSUME_PROVIDED" should fail, but the error message wasn't
clear enough in the past:

$ bitbake -e bzip2-native
[snip]
ERROR: Command execution failed: Traceback (most recent call last):
  File "/buildarea/lyang1/poky/bitbake/lib/bb/command.py", line 94, in
runAsyncCommand
    commandmethod(self.cmds_async, self, options)
  File "/buildarea/lyang1/poky/bitbake/lib/bb/command.py", line 323, in
showEnvironmentTarget
    command.cooker.showEnvironment(None, pkg)
  File "/buildarea/lyang1/poky/bitbake/lib/bb/cooker.py", line 325, in
showEnvironment
    fnid = taskdata.build_targets[targetid][0]
KeyError: 0
[snip]

With this patch, the massage will be:
[snip]
ERROR: bzip2-native is in ASSUME_PROVIDED
ERROR: Command execution failed: Exited with 1

Summary: There were 2 ERROR messages shown, returning a non-zero exit code.

[YOCTO #3392]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: hob was freezing because it doesn't receives well the log file
Cristiana Voicu [Thu, 8 Nov 2012 13:03:42 +0000 (15:03 +0200)]
hob: hob was freezing because it doesn't receives well the log file

-after pressing "build image" button, hob was freezing because it didn't
receive well the log file

[YOCTO #3398]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agocommand: add error to return of runCommand
Christopher Larson [Mon, 29 Oct 2012 20:01:23 +0000 (13:01 -0700)]
command: add error to return of runCommand

Currently, command.py can return an error message from runCommand, due to
being unable to run the command, yet few of our UIs (just hob) can handle it
today. This can result in seeing a TypeError with traceback in certain rare
circumstances.

To resolve this, we need a clean way to get errors back from runCommand,
without having to isinstance() the return value. This implements such a thing
by making runCommand also return an error (or None if no error occurred).

As runCommand now has a method of returning errors, we can also alter the
getCmdLineAction bits such that the returned value is just the action, not an
additional message. If a sync command wants to return an error, it raises
CommandError(message), and the message will be passed to the caller
appropriately.

Example Usage:

    result, error = server.runCommand(...)
    if error:
        log.error('Unable to run command: %s' % error)
        return 1

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: providing details about process state through porgress bar
Cristiana Voicu [Wed, 31 Oct 2012 13:31:07 +0000 (15:31 +0200)]
hob: providing details about process state through porgress bar

-small changes to the text of the progress bar when parsing recipes

[YOCTO #3282]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobitbake/server: Remove dead console log code
Richard Purdie [Tue, 30 Oct 2012 17:20:55 +0000 (17:20 +0000)]
bitbake/server: Remove dead console log code

This code is dead and doesn't do anything so lets remove it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agocooker.py: Don't dump the environment into the console log file
Richard Purdie [Tue, 30 Oct 2012 17:18:32 +0000 (17:18 +0000)]
cooker.py: Don't dump the environment into the console log file

Dumping the environment data into the console log files directory is
invariably not what the user wants or expects and leads to confusion
when looking at the log directory.

This change forces the logs to be disabled by default when using
the -e option.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agouihelper: Set update flag when start event encountered
Richard Purdie [Tue, 30 Oct 2012 16:42:27 +0000 (16:42 +0000)]
uihelper: Set update flag when start event encountered

Its a minor correctness detail but the update flag should be set
when Start events are encountered.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoknotty: Ensure last tasks are disaplyed correctly in the footer
Richard Purdie [Tue, 30 Oct 2012 16:39:47 +0000 (16:39 +0000)]
knotty: Ensure last tasks are disaplyed correctly in the footer

There was an issue where the last tasks run by bitbake would not
correctly get displayed in the knotty footer. This was due to the
total count including active tasks. This change ensures the footer
is displayed if the are any running tasks.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: reordering the layers in the Hob Layers dialog
Cristiana Voicu [Fri, 26 Oct 2012 13:54:47 +0000 (16:54 +0300)]
hob: reordering the layers in the Hob Layers dialog

-since the order of the layers can potentially impact
the build outcome, users should be able to reorder
the layers within the layers dialog;
-used TreeView Drag and Drop

[YOCTO #3270]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob/hig: Hob doesn't save properly proxy settings
Cristian Iorga [Fri, 26 Oct 2012 09:24:19 +0000 (12:24 +0300)]
hob/hig: Hob doesn't save properly proxy settings

User introduced proxy settings were not saved
when a proxy details input dialog was opened.
The proxy settings were lost upon return, and
restored from the previously stored one.

Also:
Code cleanup:
details_cb() function duplicate definition
removed

Fixes [YOCTO #3240]

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: during recipe parsing, progress bar text provides details about the process...
Cristiana Voicu [Thu, 25 Oct 2012 13:43:44 +0000 (16:43 +0300)]
hob: during recipe parsing, progress bar text provides details about the process state

- indicating on progress bar that hob has gone from parsing
recipes to "Generating dependency tree"; this will provide
some visibility of what has caused the "stop" button state
to change

[YOCTO #3282]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: add a progress indicator when you select 'view log'
Cristiana Voicu [Thu, 25 Oct 2012 10:36:23 +0000 (13:36 +0300)]
hob: add a progress indicator when you select 'view log'

- created a new file named "hobthreads.py", defining a thread
for opening the log file in a subprocess using subprocess module;
in the future I think we will add some other threads here, to
implement some other performance issues
- on "builddetailspage", "packageselectionpage" and "imagedetailspage"
I have changed the manner for opening the log file; it uses the thread
to open the file, and on main thread it creates a dialog to show a
progress bar, which pulses till the file is open
- this was added because when the log file is big, it takes time to
be opened; on the dialog you can use "Cancel" button to terminate the
process initiated to open the file

[YOCTO #2997]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobitbake: hob/builder: Hob crashes because of bad init
Cristian Iorga [Thu, 25 Oct 2012 15:37:30 +0000 (18:37 +0300)]
bitbake: hob/builder: Hob crashes because of bad init

Image selection is not properly initialized to none,
and it used before having a chance to have a value.
Due to dynamic nature of Python, variable is used before
it exists, in this case. This causes a crash.
Bug introduced during the fix of [YOCTO #3228]

Fixes [YOCTO #3334]

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob/settings: add a scroll bar for the box with mirrors
Cristiana Voicu [Thu, 18 Oct 2012 09:09:51 +0000 (12:09 +0300)]
hob/settings: add a scroll bar for the box with mirrors

- added a scroll bar in the shared state tab from settings
- added a signal on it, so when you add a new mirror, it will
auto-scroll to the end of the list

[YOCTO #3229]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobitbake: hob/builder: Image selection is remembered while changing adv settings
Cristian Iorga [Wed, 17 Oct 2012 14:24:06 +0000 (17:24 +0300)]
bitbake: hob/builder: Image selection is remembered while changing adv settings

Image selection is remembered correctly even after
advanced settings have been changed.
Selected image was reset even when it was not the case.

Fixes [YOCTO #3228]

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob/builddetailspage: set "Log" page as default
Cristiana Voicu [Wed, 17 Oct 2012 08:25:47 +0000 (11:25 +0300)]
hob/builddetailspage: set "Log" page as default

- when you do a build you should see "Log" page, not
"Build configuration" page

[YOCTO #2569]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob/imageconfigurationpage: progress bar shows when recipe parsing is stopped
Cristiana Voicu [Tue, 16 Oct 2012 11:23:27 +0000 (14:23 +0300)]
hob/imageconfigurationpage: progress bar shows when recipe parsing is stopped

-when the recipe parsing process is stopped, the progress bar shows
"Stopping recipe parsing"

[YOCTO #3259]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobitbake: hob/hobwidget: "Brought in by" column is now displayed correctly
Cristian Iorga [Tue, 16 Oct 2012 08:52:38 +0000 (11:52 +0300)]
bitbake: hob/hobwidget: "Brought in by" column is now displayed correctly

In "Edit Recipes" and "Edit packages" pages, the "Brought in by"
column is displayed correctly, with the right number of additional
packages and a proper title.

Fixes [YOCTO #2195].

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: stop build without percentage shown
Andrei Dinu [Fri, 12 Oct 2012 14:51:30 +0000 (17:51 +0300)]
hob: stop build without percentage shown

added a method in progressbar.py that doesn't update the
percentage in the progress bar shown in hob.

the call of the method is done in builder.py.

Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: change behavior for "cancel" button from the Recipe selection page
Cristiana Voicu [Fri, 12 Oct 2012 12:29:46 +0000 (15:29 +0300)]
hob: change behavior for "cancel" button from the Recipe selection page

-when returned to the Image configuration page, after canceling on the
Recipe selection page, the image selected previously is now shown corectly

[YOCTO #3205}
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agohob: image size displayed wrong size in edit packages screen
Andrei Dinu [Fri, 12 Oct 2012 09:06:23 +0000 (12:06 +0300)]
hob: image size displayed wrong size in edit packages screen

    size_str = '%.1f' % (size*1.0/(1024*1024)) + ' MB'
    from /bitbake/lib/bb/ui/crumbs/hobpages.py file transformed
    the size in MB. In our file it was again multiplied by 1024
    instead of doing a division by 1024, which brought a faulty size on
    the edit packages screen.

Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoevent/hob: Add a button for network tests in the proxy settings
Bogdan Marinescu [Thu, 11 Oct 2012 11:45:07 +0000 (14:45 +0300)]
event/hob: Add a button for network tests in the proxy settings

This patch allows the user to check the network connectivity in
the "Proxy" page ("Settings" dialog) by adding a button which provides
this functionality. It also disables retrigerring sanity checks if the
proxy values are changed, since now the proxy checks are explicit.
Note that this patch depends on a patch in oe-core
("sanity.bbclass: trigger network tests explicitly"). It will
not work properly if the patch in oe-core is not merged.

[YOCTO #3026]

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob-toolchain: task-core-standalone-sdk-target renamed to packagegroup-core-standalon...
Andrei Dinu [Tue, 9 Oct 2012 13:23:26 +0000 (16:23 +0300)]
hob-toolchain: task-core-standalone-sdk-target renamed to packagegroup-core-standalone-sdk-target

This change also applies to task-core-standalone-sdk-target-dbg and resolves
build failures caused by the missing packages.

Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/imageconfigurationpage: a 'hob-image' appears listed in the base image combo box
Cristiana Voicu [Mon, 8 Oct 2012 10:05:06 +0000 (13:05 +0300)]
hob/imageconfigurationpage: a 'hob-image' appears listed in the base image combo box

-remove this image from image combo box

[YOCTO #3230]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/hobeventhandler: Describe the runCommand failure exception
Constantin Musca [Fri, 5 Oct 2012 12:31:59 +0000 (15:31 +0300)]
hob/hobeventhandler: Describe the runCommand failure exception

[YOCTO #1245]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/hobeventhandler: Throw an exception if runCommand fails
Constantin Musca [Thu, 4 Oct 2012 05:15:52 +0000 (08:15 +0300)]
hob/hobeventhandler: Throw an exception if runCommand fails

- throw a Hob exception if runCommand returns 'Busy' or
'No such command'

[YOCTO #1245]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/imagedetailspage: disable the deploy tool for qemu machines
Constantin Musca [Wed, 3 Oct 2012 09:04:17 +0000 (12:04 +0300)]
hob/imagedetailspage: disable the deploy tool for qemu machines

- qemu images cannot be deployed to hardware, even if live
images (hddimg and iso) files are created

[YOCTO #3196]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/settings: alignment and spacing fixes on "Shared state" tab
Cristiana Voicu [Wed, 3 Oct 2012 10:06:22 +0000 (13:06 +0300)]
hob/settings: alignment and spacing fixes on "Shared state" tab

-alignment and separation on vertical and horizontal axis
-change controls width
[YOCTO #3188]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/image_details/run_image: Kernel must be set
Ioana Grigoropol [Wed, 3 Oct 2012 11:13:18 +0000 (14:13 +0300)]
hob/image_details/run_image: Kernel must be set

- when displaying image details, even if the kernel information is not shown, the kernel value must be set (if dealing with qemu) otherwise running the image will throw an error
Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2: raise an exception if user specifies protocol=git with http://
Paul Eggleton [Wed, 3 Oct 2012 12:27:57 +0000 (13:27 +0100)]
fetch2: raise an exception if user specifies protocol=git with 

It is a common mistake to use http:// and protocol=git when attempting
to fetch from a git repository using the http protocol; if this is
detected then throw an error explaining that you need to use git:// with
protocol=http instead.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoproviders.py: Fix PREFERRED_VERSION containing epochs
Richard Purdie [Wed, 3 Oct 2012 12:29:59 +0000 (13:29 +0100)]
providers.py: Fix PREFERRED_VERSION containing epochs

For some reason the code calls int() on the epoch component of any
PREFERRED_VERSION. Since this is compared against strings, the comparison
would always fail. This removes the stray cast and allows epochs
in preferred_version to work correctly.

[YOCTO #3187]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/hobpages: Generate the title label every time
Constantin Musca [Tue, 2 Oct 2012 14:59:45 +0000 (17:59 +0300)]
hob/hobpages: Generate the title label every time

- the title label is destroyed at page switching (that's why we need
to generate it every time)

[YOCTO #3195]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: Improved behavior for error reporting window
Cristian Iorga [Tue, 2 Oct 2012 14:44:55 +0000 (17:44 +0300)]
hob: Improved behavior for error reporting window

Scrollbars have now an automatic behavior, depending on
the error's text size and error window size.

Fixes [YOCTO #2983]

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoUpdate version to 1.16.0 1.16.0
Richard Purdie [Tue, 2 Oct 2012 10:27:13 +0000 (11:27 +0100)]
Update version to 1.16.0

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: Further improvements to hob dialogs
Bogdan Marinescu [Mon, 1 Oct 2012 13:45:25 +0000 (16:45 +0300)]
hob: Further improvements to hob dialogs

1. Replace some labels in the "Build environment" tab
2. 'defaultsetup' changed to 'Default' in the "Image types" tab
3. Fixed the moving icon in the "Output" tab

For more details: https://bugzilla.yoctoproject.org/show_bug.cgi?id=2162

[Yocto #2162]

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: Fix 'User selected' tag functionality
Constantin Musca [Mon, 1 Oct 2012 11:03:22 +0000 (14:03 +0300)]
hob: Fix 'User selected' tag functionality

- the 'User selected' tag is only used when the user
selects a package
- fix hob to remember which packages are 'User selected'
- if the package is already brought in by some other package,
it should not appear as 'User selected'

[YOCTO #3108]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/settings: Change the 'Delete' button behaviour in the shared state settings tab
Cristiana Voicu [Mon, 1 Oct 2012 09:11:29 +0000 (12:11 +0300)]
hob/settings: Change the 'Delete' button behaviour in the shared state settings tab

-the tab shows an empty mirror row when no mirror is configured
-able to delete the mirror row even if it's not empty(if it's not
the first mirror)

[YOCTO #3189]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/image_details: Remove kernel info from details
Ioana Grigoropol [Fri, 28 Sep 2012 16:06:57 +0000 (19:06 +0300)]
hob/image_details: Remove kernel info from details

- removed kernel information from image details

[Yocto #3002]

Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agotests/utils: Add test for explode_dep_versions2
Richard Purdie [Mon, 1 Oct 2012 22:06:57 +0000 (22:06 +0000)]
tests/utils: Add test for explode_dep_versions2

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoutils: Add explode_dep_versions2 to replace explode_dep_versions
Richard Purdie [Mon, 1 Oct 2012 22:03:43 +0000 (22:03 +0000)]
utils: Add explode_dep_versions2 to replace explode_dep_versions

The API for explode_dep_versions is flawed since there can only be one version
constraint against any given dependency. This adds a new function with an API
without this limitation. explode_dep_versions() is maintained with a warning
printed when its used in a situation where information is lost.

This should allow a simple transition to the new API to fix the lost dependency
information.

join_deps() is updated to deal with data in either format.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoutils.py: Allow explode_dep_versions comparisons to have arbitrary whitespace
Mark Hatle [Sun, 30 Sep 2012 00:01:45 +0000 (00:01 +0000)]
utils.py: Allow explode_dep_versions comparisons to have arbitrary whitespace

Refactor the explode_dep_versions to be more lenient on whitespace values.

The required format is:
   foo (= 1.10)
   foo (=1.10)
   foo ( = 1.10)
   foo ( =1.10)
   foo ( = 1.10 )
   foo ( =1.10 )

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoutils.py: Check for duplicate dependency entries
Mark Hatle [Sun, 30 Sep 2012 00:01:44 +0000 (00:01 +0000)]
utils.py: Check for duplicate dependency entries

explode_dep_versions is not able to have duplicate entries.  Previously
duplicate entries ended up with the last item being the one returned to
the caller.

We now detect a collision.  We do allow an empty item to have a comparison
added to it, or a duplicate with the same comparison without error.

When a collision is detected a ValueError exception is thrown.

Allowed:
   foo foo (= 1.12) foo

Invalid:
   foo (= 1.12) foo (= 1.13)

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoFix bad merge of #2162
Bogdan Marinescu [Fri, 28 Sep 2012 15:06:06 +0000 (18:06 +0300)]
Fix bad merge of #2162

This patch fixes the bad merge of #2162 fixes on master.

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: Error reports are done in a clearer way
Cristian Iorga [Fri, 28 Sep 2012 15:05:53 +0000 (18:05 +0300)]
hob: Error reports are done in a clearer way

For long errors (bigger than 200 letters),
the text box is scrollable and resizable
and text is selectable.

Additionaly, all message dialogs are modal.
Otherwise, a user could still interact with hob
even in an error case, leading to potential problems.

See design details in related bugs.

Fixes [YOCTO #2960], [YOCTO #2983]

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/builddetailspage: fix failure_primary_action_button_clicked_cb
Constantin Musca [Fri, 28 Sep 2012 12:37:48 +0000 (15:37 +0300)]
hob/builddetailspage: fix failure_primary_action_button_clicked_cb

[YOCTO #3194]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/builddetailspage: remove "back" button
Cristiana Voicu [Fri, 28 Sep 2012 12:50:12 +0000 (15:50 +0300)]
hob/builddetailspage: remove "back" button

When a build fails, there should not be a back button on the screen.
All available actions are provided within the failure notification,
so no back button is needed.

[YOCTO #3104]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoknotty: Allow displaying of status when no tasks are active
Richard Purdie [Thu, 27 Sep 2012 21:56:02 +0000 (21:56 +0000)]
knotty: Allow displaying of status when no tasks are active

The console can appear to hang when no tasks are executing even if bitbake
is iterating through a large number of tasks behind the scenes.

This patch tweaks the footer code to display a status even when no tasks
are active to give the user better feedback about what is happening.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoparse/ConfHandler: Add negative lookahead to spot some quoting problems
Richard Purdie [Thu, 27 Sep 2012 22:07:28 +0000 (23:07 +0100)]
parse/ConfHandler: Add negative lookahead to spot some quoting problems

Syntax like:

FOO = "bar" # eek"

would result in FOO taking the value 'bar" #eek' which is clearly
not the intention. Whilst our metadata is riddled with mixtures of even
quotes like:

FOO = "d.getVar("X")"

odd numbers of quotes seem rare. This patch adds detection of one odd
quote which we don't have any of in OE-Core so it seems a valid sanity
improvement.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: set modal flag on progress dialog
Ross Burton [Thu, 27 Sep 2012 15:46:09 +0000 (16:46 +0100)]
hob: set modal flag on progress dialog

The entire interface isn't usable whilst the progress dialog is up so we might
as well set the modal flag so that some WMs (such as GNOME 3) can do nice things
with the dialog (such as pin it to the titlebar).

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/settings: implement a new tab in settings dialog to show SSTATE_MIRRORS
Cristiana Voicu [Wed, 26 Sep 2012 10:44:08 +0000 (13:44 +0300)]
hob/settings: implement a new tab in settings dialog to show SSTATE_MIRRORS

Add a new tab to show correctly SSTATE_MIRRORS variable. Now you can add new
mirrors or delete mirror. "info" image was also changed( it is smaller, so it
can be next to labels).
>From "Build environment" tab, SSTATE_DIR and SSTATE_MIRRORS vars were removed.

[YOCTO #2893]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoAdd missing file from previous commit
Richard Purdie [Fri, 28 Sep 2012 08:55:57 +0000 (09:55 +0100)]
Add missing file from previous commit

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/builder: When you stop a build, Hob should tell you stopping is happening
Constantin Musca [Wed, 26 Sep 2012 08:08:15 +0000 (11:08 +0300)]
hob/builder: When you stop a build, Hob should tell you stopping is happening

- use the progress bar text to indicate the stopping status
- the text should say: 'Stopping the build...'

[YOCTO #3152]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agolib/bb/data.py: improve output for expansion errors
Paul Eggleton [Tue, 25 Sep 2012 14:17:17 +0000 (15:17 +0100)]
lib/bb/data.py: improve output for expansion errors

Instead of logging the function/variable separately as a NOTE when
failing to expand, re-raise ExpansionError with more contextual
information. This means that the full details are reported in Hob as
well as actually reporting the original error message in any UI where
we previously did not. For example, we used to get this with tab/space
indentation issues in a python function:

NOTE: Error expanding variable populate_packages
ERROR: Unable to parse /path/to/recipename.bb

Now, we will get this:

ERROR: ExpansionError during parsing /path/to/recipename.bb: Failure
 expanding variable populate_packages: IndentationError: unindent does
 not match any outer indentation level (<string>, line 4)

Fixes [YOCTO #3162].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agocooker: adjust layer dependency error messages
Paul Eggleton [Tue, 25 Sep 2012 15:25:28 +0000 (16:25 +0100)]
cooker: adjust layer dependency error messages

Make these a little easier to understand.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/recipeselectionpage: recipes should not be shown brought in by themselves
Cristiana Voicu [Thu, 27 Sep 2012 14:12:59 +0000 (17:12 +0300)]
hob/recipeselectionpage: recipes should not be shown brought in by themselves

[YOCTO #3107]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2: add "-d" option to cpio
Robert Yang [Wed, 26 Sep 2012 09:07:57 +0000 (17:07 +0800)]
fetch2: add "-d" option to cpio

Add "-d" option to cpio since it is useful:
  -d
  --make-directories
  Create leading directories where needed.

[YOCTO #3137]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoMultiple user interface fixes in settings
Bogdan Marinescu [Thu, 27 Sep 2012 14:13:45 +0000 (17:13 +0300)]
Multiple user interface fixes in settings

1. Move the "Others" tab from advanced settings to simple settings
2. Organize content of tabs into headings
3. Match various labels in the settings with the design
4. Clean up config_md5 in both simple and advanced settings

This patch implements a part of the changes requested by Belen in the settings dialogs.
The second version of the patch addresses all the UI changes requested by Belen (more
details are in the bug description): alphabetical ordering of the image types and
warnings if no image type is selected.

[YOCTO #2162]

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/runningbuild: Add missing logging level argument
Constantin Musca [Thu, 27 Sep 2012 10:49:12 +0000 (13:49 +0300)]
hob/runningbuild: Add missing logging level argument

[YOCTO #3170]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoAdd sanity check progress screen
Bogdan Marinescu [Wed, 26 Sep 2012 13:59:57 +0000 (16:59 +0300)]
Add sanity check progress screen

This patch adds a sanity check progress screen to hob. The screen
is displayed when Hob executes the sanity check procedure. The screen
is displayed for at least 5 seconds. If a network error is detected,
a special dialog is displayed which lets the user open the proxy
configuration page directly.
Note that currently bitbake triggers the network tests only when
the value of its TMPDIR variable changes, which happens fairly rare
on my system. This is the subject of another bug (#3026).
Version 2 of the patch splits the changes in two parts (sanity.bbclass
belongs to oe-core).

[YOCTO #3025]

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/builddetailspage: change branch field
Cristiana Voicu [Wed, 26 Sep 2012 13:11:41 +0000 (16:11 +0300)]
hob/builddetailspage: change branch field

When a user makes a build from a tarball, it shows fatal error in branch field.
Now it not complains as a fatal error. It is a normal message.

[YOCTO #3114]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: Buttons width and height are taken for host
Ioana Grigoropol [Wed, 26 Sep 2012 12:13:42 +0000 (15:13 +0300)]
hob: Buttons width and height are taken for host

- removed all set_size_request calls for buttons in order to:
- force autosizing of buttons with regard to the text length
- use host theme default height for buttons
- modified buttons on image details page to have the same height (default host one) and the width of the button with the largest text
- modified Stop button on build details page to have the default height by directly attaching it to the containing table instead of hbox

Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/settings: implement a new tab in settings dialog to show SSTATE_MIRRORS
Cristiana Voicu [Wed, 26 Sep 2012 10:44:08 +0000 (13:44 +0300)]
hob/settings: implement a new tab in settings dialog to show SSTATE_MIRRORS

Add a new tab to show correctly SSTATE_MIRRORS variable. Now you can add new
mirrors or delete mirror. "info" image was also changed( it is smaller, so it
can be next to labels).
>From "Build environment" tab, SSTATE_DIR and SSTATE_MIRRORS vars were removed.

[YOCTO #2893]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2/git: Don't use deprecated API
Richard Purdie [Tue, 25 Sep 2012 14:55:27 +0000 (15:55 +0100)]
fetch2/git: Don't use deprecated API

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/packageselectionpage:cancel button should redirect to Image conf screen
Cristiana Voicu [Mon, 24 Sep 2012 13:30:59 +0000 (16:30 +0300)]
hob/packageselectionpage:cancel button should redirect to Image conf screen

Cancel button brings you to Image configuration page.

[YOCTO #3105]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/builddetailspage: change tooltips and remove a dialog from "Build stopped" message
Cristiana Voicu [Mon, 24 Sep 2012 12:17:58 +0000 (15:17 +0300)]
hob/builddetailspage: change tooltips and remove a dialog from "Build stopped" message

When you stop a build, a "Build stopped" message appears. I have changed 2 tooltips and
also eliminate the alert that comes up when you click 'Edit packages'.

[YOCTO #3160]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agobitbake: Unbuffer stdout for log files
Jason Wessel [Mon, 17 Sep 2012 22:43:31 +0000 (17:43 -0500)]
bitbake: Unbuffer stdout for log files

It is possible to lose critical log data when python exits in an
unorderly fashion via segmentation fault or certain types of crashes.
This is because the buffer characteristics are inherited from the top
level stdout, which should be set to unbuffered, for the purpose of
all the forked children.

This pushes the buffering to the OS, instead of having python managing
the buffers in its stream handler class.

This change is also to provide the ability to tail logs written from
processes in "real time" because they would be written in an orderly
fashion depending upon the OS characteristics for the file I/O.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoevent.py, knotty.py, ncurses.py, runningbuild.py: Add support for LogExecTTY event
Jason Wessel [Mon, 17 Sep 2012 22:43:49 +0000 (17:43 -0500)]
event.py, knotty.py, ncurses.py, runningbuild.py: Add support for LogExecTTY event

The LogExecTTY even is intended to provide the ability to spawn a task
on a the controlling tty, if a tty is availble.  When a controlling
tty is not availble the previous behavior is preserved where a warning
is issued about the action an end user must execute.

All the available UI's were tested against the new event type.

This feature is primarily intended for hooking up a screen client
session automatically on the controlling tty to allow for a more
streamlined end user experience when using a pure command line driven
environment.  The changes that send the LogExecTTY event are in the
oe-core side.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agoprogress.py: Fix traceback when running goggle ui
Jason Wessel [Mon, 17 Sep 2012 22:43:48 +0000 (17:43 -0500)]
progress.py: Fix traceback when running goggle ui

The following traceback appears when running the following command after the
devshell is exited.

bitbake -u goggle -c devshell busybox

-- traceback --
Traceback (most recent call last):
  File "/work/bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
    build.handle_event (event, pbar)
  File "/work/bitbake/lib/bb/ui/crumbs/runningbuild.py", line 299, in handle_event
    pbar.set_text(event.msg)
AttributeError: 'ProgressBar' object has no attribute 'set_text'

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agorunqueue: Add --no-setscene to skip all setscene tasks
Jason Wessel [Mon, 17 Sep 2012 22:43:17 +0000 (17:43 -0500)]
runqueue: Add --no-setscene to skip all setscene tasks

Mainly intended for the purpose of debugging or forcing builds
from source, the --no-setscene will prevent any setscene
tasks from running.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2/git: Add missing mkdir
Richard Purdie [Mon, 24 Sep 2012 08:37:09 +0000 (08:37 +0000)]
fetch2/git: Add missing mkdir

bitbake-selftest is failing due to directories not being created. This adds in an
appropriate mkdir so the tests can complete. Presumably in general OE use, something
else is ensuring the parent directory is created.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2: improve error output for checksum failures
Paul Eggleton [Sun, 23 Sep 2012 17:05:36 +0000 (18:05 +0100)]
fetch2: improve error output for checksum failures

* Don't print the full exception in the initial warning - if we later
  succeed in fetching the file from a mirror, we won't usually need the
  details (which are in the fetch log if they are needed); otherwise the
  full error will be printed when the fetch operation fails. Also adjust
  the conditional block so that we don't print another warning just
  mentioning we're going to try mirrors.
* Call logger.error() so that with knotty the full log is not printed
* Provide an explanation around the lines we print for easily updating
  the checksums in the recipe. We don't want users to be just blindly
  updating the recipe in case of a transient failure or deliberately
  altered remote file.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2: make fetch failure errors more readable
Paul Eggleton [Sun, 23 Sep 2012 17:05:35 +0000 (18:05 +0100)]
fetch2: make fetch failure errors more readable

Most of the time we don't need to see the fetch command; the fetch log
includes the command as a debug message in any case, so omit it. Also
adjust the way command output is printed (we don't need stderr/stdout
labelled, and print "no output" instead of "output:\nNone" when there is
no output.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agolib/bb/runqueue.py: fix exceptions with -k and failed targets
Paul Eggleton [Sun, 23 Sep 2012 13:14:24 +0000 (14:14 +0100)]
lib/bb/runqueue.py: fix exceptions with -k and failed targets

If a target dependency is marked as failed and yet we are continuing on
because -k has been specified, don't try to access the dependency's data
in taskData.build_targets since it will have been removed. This fixes
"IndexError: list index out of range" errors in this situation.

Also, do not print the "unhandled exception" message when SystemExit is
raised since we will have reported the actual error already in this
case (e.g. when -k has been specified and some targets failed).

Fixes [YOCTO #3133].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: fix Gtk-WARNINGs due to invalid markup on Back button
Paul Eggleton [Fri, 21 Sep 2012 14:47:26 +0000 (15:47 +0100)]
hob: fix Gtk-WARNINGs due to invalid markup on Back button

You can't use markup characters (e.g '<' or '>') in the labels for many
widgets - you must use the appropriate entities instead.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: remove confirmation dialog on close
Paul Eggleton [Fri, 21 Sep 2012 14:47:25 +0000 (15:47 +0100)]
hob: remove confirmation dialog on close

This is not necessary for modern applications - instead we just need to
check if we're in the middle of a build and if so, do the same thing as
pressing the "Stop" button.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: allow configuring default machine using HOB_MACHINE
Paul Eggleton [Fri, 21 Sep 2012 14:47:24 +0000 (15:47 +0100)]
hob: allow configuring default machine using HOB_MACHINE

Allow specifying HOB_MACHINE in local.conf to set the initially
selected machine. With this set, Hob will select the specified machine
and then jump straight into parsing recipes. If you do wish to change
the selected machine with HOB_MACHINE set you still can - you just need
to stop the parsing process first.

Fixes [YOCTO #3148].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: don't show error dialog for errors during building
Paul Eggleton [Fri, 21 Sep 2012 14:47:23 +0000 (15:47 +0100)]
hob: don't show error dialog for errors during building

During building we already report errors in a special tab and
indicate when the build has failed; bringing up a dialog was a
regression introduced in bitbake revision
5bab81b124087d63d6eb62a861e1241714fcd483.

Fixes [YOCTO #3151].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: The title of the packages screen depends on the screen you arrive from
Constantin Musca [Fri, 21 Sep 2012 10:28:43 +0000 (13:28 +0300)]
hob: The title of the packages screen depends on the screen you arrive from

- If you arrive to the packages screen from the recipes screen, the title
should say: 'Step 2 of 2: Edit packages'
- If you arrive to the packages screen from the image details screen, the
title should say: 'Edit packages'
- The title of the recipes screen should say 'Step 1 of 2: Edit recipes'

[YOCTO #2982]

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: Don't set busy cursor on the root window, just our window
Ross Burton [Tue, 18 Sep 2012 14:55:24 +0000 (15:55 +0100)]
hob: Don't set busy cursor on the root window, just our window

[ YOCTO #3127 ]

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: add a top bar when building process is stopped
Cristiana Voicu [Tue, 18 Sep 2012 15:15:55 +0000 (18:15 +0300)]
hob: add a top bar when building process is stopped

When a build was stopped, it wasn't obvious what to do next.
Now, on the page it appers a top bar with 3 buttons: "edit image",
"open log", "build new image"

[YOCTO #2537]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agocooker: Clarify package/recipe wording
Trevor Woerner [Wed, 19 Sep 2012 03:00:33 +0000 (23:00 -0400)]
cooker: Clarify package/recipe wording

When the '-s' option is run, change the heading above the list of recipes
to say "Recipe Name" instead of "Package Name".

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/packageselectionpage: "Cancel" button returns to "Image configuration" screen
Cristiana Voicu [Wed, 19 Sep 2012 07:36:57 +0000 (10:36 +0300)]
hob/packageselectionpage: "Cancel" button returns to "Image configuration" screen

Once package building completes, you can customise the list of
packages that will go into the final image. Once you have made
the changes you need, you can either build your image, or you
can exit the process and go back to the 'Image configuration'
screen by selecting 'Cancel'.

[YOCTO #3105]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob: report event handler failures
Paul Eggleton [Wed, 19 Sep 2012 10:25:42 +0000 (11:25 +0100)]
hob: report event handler failures

If an event handler failed we were not recieving an error message -
parsing just "froze" at 99%. This is because we were expecting a
CommandFailure event and this never happened in the case of
RequestPackageInfo which is where the failure was occurring.

This also required tweaking the error formatting slightly, taking the
return value of the format function rather than the message property
since the latter only seems to contain the first line without the
traceback in the case of event handler failure. Other error cases were
tested and their message formatting is unaffected by this change.

Final part of the fix for [YOCTO #2651].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agohob/settings: Remove stray "distro" combobox from simple settings
Bogdan Marinescu [Thu, 20 Sep 2012 10:27:56 +0000 (13:27 +0300)]
hob/settings: Remove stray "distro" combobox from simple settings

The "distro" combobox was moved to advanced settings, but it
was also present in simple settings. This patch removed it
from simple settings.

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agobuild/siggen: Add support for stamp 'clean' masks
Richard Purdie [Tue, 18 Sep 2012 10:32:04 +0000 (11:32 +0100)]
build/siggen: Add support for stamp 'clean' masks

Currently when we execute a task, we don't remove other potentially stale
stamps. This can mean if you switch between two different versions of a
recipe without a clean, the build can get very confused.

This patch adds in functionality to allow a wildcard expression of stamp
files to be removed when creating a new stamp file. This patch adds in
the core of the code to enable this but it also requires metadata support
to enable it.

When writing this improvement I went through several different options but
this was the only way I could find to allow things like noexec tasks to
function correctly (where stamps need to be created without the data store).

[YOCTO #2961]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2/cvs: Fix parameter spacing
Richard Purdie [Thu, 20 Sep 2012 10:34:18 +0000 (11:34 +0100)]
fetch2/cvs: Fix parameter spacing

Add in misssing space between the parameters. Reported by
Jate Sujjavanich <Jate.Sujjavanich@myfuelmaster.com>.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2/cvs: Clean up various data store references
Richard Purdie [Thu, 20 Sep 2012 10:32:02 +0000 (11:32 +0100)]
fetch2/cvs: Clean up various data store references

The code in the CVS fetcher is elderly and there are simpler ways of
using the data store. This updates to use the modern APIs.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
7 years agofetch2/cvs: Fix localdata variable reference
Richard Purdie [Thu, 20 Sep 2012 10:25:19 +0000 (11:25 +0100)]
fetch2/cvs: Fix localdata variable reference

The localdata variable was removed, fix up a lost reference to this.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>